Message263710
| Author |
serhiy.storchaka |
| Recipients |
abarry, martin.panter, serhiy.storchaka |
| Date |
2016年04月19日.05:45:45 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1461044745.2.0.763604576321.issue26801@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
> What platform do you get the AttributeError with? Perhaps the function is not well covered in the test suite.
I guess `os.get_terminal_size()` didn't exist on ancient OSes like DOS, OS/2, ancient UNIXes. On all supported platforms (including such exotic as old AIX, QNX or Minix) it should be defined.
Tests should fail if `os.get_terminal_size()` doesn't exist.
> I think Rietveld doesn't like me because I made it a .diff file, and not a .patch file, but who knows.
I think this is because the patch doesn't contain a revision number.
On Windows `os.get_terminal_size()` can raise ValueError if `sys.__stdout__.fileno()` is not one of 0, 1 or 2. It is worth to catch it too. An AttributeError is also raised if sys.__stdout__ has no the "fileno" attribute (StringIO or None). |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2016年04月19日 05:45:45 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, martin.panter, abarry |
| 2016年04月19日 05:45:45 | serhiy.storchaka | set | messageid: <1461044745.2.0.763604576321.issue26801@psf.upfronthosting.co.za> |
| 2016年04月19日 05:45:45 | serhiy.storchaka | link | issue26801 messages |
| 2016年04月19日 05:45:45 | serhiy.storchaka | create |
|