Message262816
| Author |
vstinner |
| Recipients |
Arfrever, dfarrell07, martin.panter, ned.deily, orsenthil, python-dev, r.david.murray, vstinner |
| Date |
2016年04月03日.07:15:22 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1459667723.26.0.933607216486.issue21069@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I added a timeout because test_urllibnet fails with a timeout after 15 minutes on the ARM buildbot and other tests of the same file also use a timeout.
I tried but failed to reproduce the timeout.
I ran the test after my change and it passes so I considered that it was ok. I understand your rationale for timeout, non blocking socket and read() returning None.
Can we modify the test to use a selector to wait until the socket is ready and only read available bytes, rather than reading all data?
Using a local server would also avoid blocking too long (take less than 15 min). |
|