Message262663
| Author |
palaviv |
| Recipients |
SilentGhost, christian.heimes, gregory.p.smith, martin.panter, palaviv, rhettinger, terry.reedy, vstinner |
| Date |
2016年03月30日.13:03:14 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1459342996.52.0.652143621951.issue26488@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Sorry on the late response for some reason i don't receive email notification from the tracker for the past few days.
1) Thanks for the review SilentGhost the patch attached include your CR suggestions.
2) Raymond I have fixed the problem with ctrl+D. I tried writing a test to simulate this problem but i don't seem to be able to simulated the terminal behavior on ctrl+D.
3) Removed the block_size option as suggested by Raymond and Victor and using os.stat().st_blksize as suggested by Victor.
4) I changed the CLI to support all available algorithms in hashlib. I am not sure if this is too many choices to show in the --help message.
5) About removing the use of argparse.FileType i would prefer resolving issue 14156 but if you think this is problematic i will do the change.
6) What do you think about changing the API to be more like md5sum?
a) Allowing * in the file name to calcualte on multiple files.
b) Adding the check option.
c) printing file name in output. |
|