Message 261487 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	martin.panter
Recipients	Alex.Willmer, martin.panter, paul.moore, rpetrov, steve.dower, tim.golden, zach.ware
Date	2016年03月10日.09:30:53
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1457602253.3.0.265501193726.issue17590@psf.upfronthosting.co.za>

Content
What’s the point of allowing each macro to already be defined? I understand they may also be defined by PC/pyconfig.h, but is that possible if __MINGW32__ is defined? Is the __MINGW32__ condition needed at all? Maybe we can just blindly rely on the _WIN32 etc macros. Perhaps the PC/pyconfig.h definitions could be removed in favour of the ones in "pyport.h"?

Content

What’s the point of allowing each macro to already be defined? I understand they may also be defined by PC/pyconfig.h, but is that possible if __MINGW32__ is defined?
Is the __MINGW32__ condition needed at all? Maybe we can just blindly rely on the _WIN32 etc macros. Perhaps the PC/pyconfig.h definitions could be removed in favour of the ones in "pyport.h"?

History
Date	User	Action	Args
2016年03月10日 09:30:53	martin.panter	set	recipients: + martin.panter, paul.moore, tim.golden, rpetrov, zach.ware, steve.dower, Alex.Willmer
2016年03月10日 09:30:53	martin.panter	set	messageid: <1457602253.3.0.265501193726.issue17590@psf.upfronthosting.co.za>
2016年03月10日 09:30:53	martin.panter	link	issue17590 messages
2016年03月10日 09:30:53	martin.panter	create

homepage