Message259750
| Author |
serhiy.storchaka |
| Recipients |
Kunal Grover, anish.shah, demian.brecht, jaraco, serhiy.storchaka |
| Date |
2016年02月06日.20:24:48 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1454790288.64.0.0551095174746.issue26302@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
_LegalChars contained only characters which don't require quoting, as documented in the comment above. If _LegalChars was only used to create _is_legal_key, we would just wrote the regular expression. But it is used also in other places. In this particular case adding "\" to _LegalChars doesn't lead to visible bug (except inconsistency with the comment), but we can't be sure.
_is_legal_key() is implementation detail. It would be better to test public API. |
|