Message257423
| Author |
xdegaye |
| Recipients |
benhoyt, r.david.murray, serhiy.storchaka, vstinner, xdegaye |
| Date |
2016年01月03日.16:30:28 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1451838628.95.0.489283921105.issue25596@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I may be missing something, anyway here are few comments on the patch:
Is the call to entry.is_symlink() in _iterdir() necessary since is_dir() follows symlinks ?
If _iterdir() would yield the DirEntry instance instead of DirEntry.name, then _rlistdir() could use x.is_dir() to know whether it is correct to iterate over _rlistdir(x.path, dironly) |
|