homepage

> New changeset 136ad559fa4f by Brett Cannon in branch '2.7':
> Issue #25188: Add -P/--pgo to test.regrtest for PGO building.
> https://hg.python.org/cpython/rev/136ad559fa4f
> 
> + # required to permit running tests with PGO flag on/off
> + if pgo:
> + args_tuple[1]['pgo']=pgo
This looks ugly.
The following change should work and would be consistent with handling of huntrleaks and use_resources:
--- Lib/test/regrtest.py
+++ Lib/test/regrtest.py
@@ -508,7 +508,8 @@
 for test in tests:
 args_tuple = (
 (test, verbose, quiet),
- dict(huntrleaks=huntrleaks, use_resources=use_resources)
+ dict(huntrleaks=huntrleaks, use_resources=use_resources,
+ pgo=pgo)
 )
 yield (test, args_tuple)
 pending = tests_and_args()
@@ -526,9 +527,6 @@
 except StopIteration:
 output.put((None, None, None, None))
 return
- # required to permit running tests with PGO flag on/off
- if pgo:
- args_tuple[1]['pgo']=pgo
 # -E is needed by some tests, e.g. test_import
 popen = Popen(base_cmd + ['--slaveargs', json.dumps(args_tuple)],
 stdout=PIPE, stderr=PIPE,