Message251656
| Author |
berker.peksag |
| Recipients |
Arfrever, David.Edelsohn, Edd.Barrett, Maxime Belanger, benjamin.peterson, berker.peksag, bkabrda, dmalcolm, geoffreyspear, ischwabacher, jcea, ned.deily, pitrou, python-dev, rpointel, vajrasky, vlee, vstinner |
| Date |
2015年09月26日.16:53:56 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1443286436.73.0.750131879758.issue19884@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
The version check doesn't work because 0ed1801bf4bd added #ifndef __APPLE__ to guard the code, so if you're using readline on OS X, that rl_variable_bind workaround won't work.
There are two alternatives:
1) convert ifndef to ifdef and add a check for the ``using_libedit_emulation`` variable.
#ifdef __APPLE__
if (using_libedit_emulation) {
...
...
looks like a common idiom in readline.c.
2) just skip the test if _READLINE_VERSION < 0x0603 |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2015年09月26日 16:53:57 | berker.peksag | set | recipients:
+ berker.peksag, jcea, pitrou, vstinner, benjamin.peterson, ned.deily, Arfrever, dmalcolm, geoffreyspear, python-dev, rpointel, bkabrda, David.Edelsohn, vajrasky, Edd.Barrett, ischwabacher, vlee, Maxime Belanger |
| 2015年09月26日 16:53:56 | berker.peksag | set | messageid: <1443286436.73.0.750131879758.issue19884@psf.upfronthosting.co.za> |
| 2015年09月26日 16:53:56 | berker.peksag | link | issue19884 messages |
| 2015年09月26日 16:53:56 | berker.peksag | create |
|