Message 251472 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	martin.panter
Recipients	berker.peksag, martin.panter, s-wakaba
Date	2015年09月24日.00:37:39
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1443055063.44.0.892478253066.issue25211@psf.upfronthosting.co.za>

Content
I will commit your patch to 2.7. Here is a my alternative proposal for 3.4+, dropping the Frm class and using subTest() instead. I kept some error messages where I thought they added clarity, but dropped most because I thought they were redundant with the test code and subTest() parameters. The test file takes a bit longer to run as a consequence of my patch (was 6.3 s, now 7.3 s). However I think the simpler and more maintainable code outweighs this.

Content

I will commit your patch to 2.7.
Here is a my alternative proposal for 3.4+, dropping the Frm class and using subTest() instead. I kept some error messages where I thought they added clarity, but dropped most because I thought they were redundant with the test code and subTest() parameters.
The test file takes a bit longer to run as a consequence of my patch (was 6.3 s, now 7.3 s). However I think the simpler and more maintainable code outweighs this.

History
Date	User	Action	Args
2015年09月24日 00:37:43	martin.panter	set	recipients: + martin.panter, s-wakaba, berker.peksag
2015年09月24日 00:37:43	martin.panter	set	messageid: <1443055063.44.0.892478253066.issue25211@psf.upfronthosting.co.za>
2015年09月24日 00:37:43	martin.panter	link	issue25211 messages
2015年09月24日 00:37:42	martin.panter	create

homepage