Message250993
| Author |
jbeck |
| Recipients |
dstufft, jbeck, python-dev, tim.peters, vstinner |
| Date |
2015年09月18日.14:17:48 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1442585869.17.0.788778546118.issue25003@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I have tested your patch with 3.5, and it works fine, although I did have to make a minor change to get test_os to pass. In test_os.py you had:
...
USE_GETENTROPY = ((sysconfig.get_config_var('HAVE_GETENTROPY') == 1)
and not sys.platform.startswith("sunos"))
HAVE_GETRANDOM = (sysconfig.get_config_var('HAVE_GETRANDOM_SYSCALL') == 1)
@unittest.skipIf(USE_GETENTROPY,
"getentropy() does not use a file descriptor")
@unittest.skipIf(HAVE_GETRANDOM,
"getrandom() does not use a file descriptor")
...
whereas I came up with this:
...
USE_GETENTROPY = ((sysconfig.get_config_var('HAVE_GETENTROPY') == 1)
and not sys.platform.startswith("sunos"))
HAVE_GETRANDOM = (sysconfig.get_config_var('HAVE_GETRANDOM') == 1)
HAVE_GETRANDOM_SYSCALL = (sysconfig.get_config_var('HAVE_GETRANDOM_SYSCALL') == 1)
@unittest.skipIf(USE_GETENTROPY,
"getentropy() does not use a file descriptor")
@unittest.skipIf(HAVE_GETRANDOM,
"getrandom() does not use a file descriptor")
@unittest.skipIf(HAVE_GETRANDOM_SYSCALL,
"getrandom() does not use a file descriptor")
... |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2015年09月18日 14:17:49 | jbeck | set | recipients:
+ jbeck, tim.peters, vstinner, python-dev, dstufft |
| 2015年09月18日 14:17:49 | jbeck | set | messageid: <1442585869.17.0.788778546118.issue25003@psf.upfronthosting.co.za> |
| 2015年09月18日 14:17:49 | jbeck | link | issue25003 messages |
| 2015年09月18日 14:17:48 | jbeck | create |
|