Message 249756 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	Yi Ding, mpaolini, ned.deily, rbcollins, ronaldoussoren, vstinner
Date	2015年09月04日.12:12:55
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<CAMpsgwYB=JGuwpbYMSJXVkfLNPD3Ciw6seNdK4=H40jpx3X3oA@mail.gmail.com>
In-reply-to	<1441364937.25.0.0266598801626.issue24891@psf.upfronthosting.co.za>

Content
Yes, it looks like a good approach. Some comments: - please mention this issue "Issue #24891" and explain the issue in a comment in create_stdio_checked() - it would be safer to check the exception type, to be extra safe - you must clear the exception - why not putting the code in create_stdio() directly?

Content

Yes, it looks like a good approach. Some comments:
- please mention this issue "Issue #24891" and explain the issue in a
comment in create_stdio_checked()
- it would be safer to check the exception type, to be extra safe
- you must clear the exception
- why not putting the code in create_stdio() directly?

History
Date	User	Action	Args
2015年09月04日 12:12:55	vstinner	set	recipients: + vstinner, ronaldoussoren, rbcollins, ned.deily, mpaolini, Yi Ding
2015年09月04日 12:12:55	vstinner	link	issue24891 messages
2015年09月04日 12:12:55	vstinner	create

homepage