Message247499
| Author |
rbcollins |
| Recipients |
belopolsky, dstufft, eric.araujo, rbcollins |
| Date |
2015年07月28日.03:45:19 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1438055119.82.0.847017897565.issue23426@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
The change in exec doesn't make sense to me (but see lower :))
__file__ should be in globals, not locals, right?
Also if it is right, then exec(foo, g) should be equivalent :)
The reset of the patch looks ok. But I can see your patch shows this breaking - I'm guessing its one of the things I keep forgetting about module scope evaluation and the import system - anyhoo.
Applying to 3.6.
Also looking at it the saving of argv is still broken even with your patch - the original argv is mutated, and the /name/ not the /value/ is restored. We should rebind argv to the copy, then restore the binding. But that can be done later. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2015年07月28日 03:45:19 | rbcollins | set | recipients:
+ rbcollins, belopolsky, eric.araujo, dstufft |
| 2015年07月28日 03:45:19 | rbcollins | set | messageid: <1438055119.82.0.847017897565.issue23426@psf.upfronthosting.co.za> |
| 2015年07月28日 03:45:19 | rbcollins | link | issue23426 messages |
| 2015年07月28日 03:45:19 | rbcollins | create |
|