Message245813
| Author |
meador.inge |
| Recipients |
larry, meador.inge, ncoghlan, rhettinger, serhiy.storchaka, yselivanov |
| Date |
2015年06月25日.15:36:18 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1435246578.91.0.674488559113.issue24483@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I did some regression testing and reviewed the code; LGTM.
As for the code structure issues, I agree that the duplication is undesirable (the readability argument is not that convincing), but Serhiy's patch is consistent with the existing design. As such, I think the structure issue is a separate one and definitely should not hold this patch up. |
|