Message245802
| Author |
martin.panter |
| Recipients |
Unit03, berker.peksag, martin.panter, maurosr, milap.py, python-dev, r.david.murray, serhiy.storchaka, taddeimania |
| Date |
2015年06月25日.06:02:58 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1435212178.76.0.250383041021.issue23883@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Jacek: If we used the ModuleType check, and somebody adds a module-level constant (like logging.CRITICAL = 50), the test will automatically detect if they forget to update __all__. That is what I meant by the test being stricter. But it looks like you went for the other option, which has its own relative advantages :)
Will try to to a proper review later when I get a chance. |
|