Message244857
| Author |
martin.panter |
| Recipients |
Michiel.de.Hoon, martin.panter, mdehoon, r.david.murray, serhiy.storchaka, vstinner |
| Date |
2015年06月05日.07:28:45 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1433489330.03.0.684084520293.issue23237@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
My previous comments were about trying to maintain backwards compatibility. E.g. with the current patches, an old PyOS_InputHook() that happened to always return a negative value would mean the input never gets checked by the new Python code. I dunno what the policy on changing the C API though. Perhaps people are happy changing this in 3.6.
Also, the signal handling isn’t perfect in tkinter (e.g. it doesn’t account for non-SIGINT handlers), but perhaps practicality and simplicity beat purity here and we can say it is good enough :)
I am posting hook-interrupt.3.6.patch, which combines the readline and tkinter patches and fixes them up for Python 3. Also added some notes to the PyOS_InputHook documentation. |
|