Message 244208 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	rhettinger
Recipients	Cesar.Kawakami, Devin Jeanpierre, Kyle.Buzsaki, Rahul Gupta, amaury.forgeotdarc, berker.peksag, eryksun, ezio.melotti, ionelmc, mark.dickinson, martin.panter, ncoghlan, r.david.murray, rhettinger
Date	2015年05月27日.17:47:39
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1432748859.49.0.419771343335.issue23275@psf.upfronthosting.co.za>

Content
Berker's patch looks good. It has several virtues: * the error message is reasonable and clear * it makes the language more consistent * it doesn't break any existing code. * it makes the AST a little simpler and faster by removing a special case The patch needs to updated: * remove the whatsnew entry * fix test_codeop which expects "del ()" to raise SyntaxError * fix test_syntax which fails on "() = 1" and "del ()" * fix test_with which fails on "with mock as ()"

Content

Berker's patch looks good.
It has several virtues:
* the error message is reasonable and clear
* it makes the language more consistent
* it doesn't break any existing code.
* it makes the AST a little simpler and faster
 by removing a special case
The patch needs to updated:
* remove the whatsnew entry
* fix test_codeop which expects "del ()" to raise SyntaxError
* fix test_syntax which fails on "() = 1" and "del ()"
* fix test_with which fails on "with mock as ()"

History
Date	User	Action	Args
2015年05月27日 17:47:39	rhettinger	set	recipients: + rhettinger, amaury.forgeotdarc, mark.dickinson, ncoghlan, Devin Jeanpierre, ezio.melotti, ionelmc, r.david.murray, berker.peksag, martin.panter, eryksun, Cesar.Kawakami, Kyle.Buzsaki, Rahul Gupta
2015年05月27日 17:47:39	rhettinger	set	messageid: <1432748859.49.0.419771343335.issue23275@psf.upfronthosting.co.za>
2015年05月27日 17:47:39	rhettinger	link	issue23275 messages
2015年05月27日 17:47:39	rhettinger	create

homepage