Message 241985 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	vstinner
Recipients	boya, giampaolo.rodola, loewis, pitrou, python-dev, santoso.wijaya, serhiy.storchaka, terry.reedy, vstinner, worr, zach.ware
Date	2015年04月24日.22:26:39
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1429914400.15.0.868795997397.issue9246@psf.upfronthosting.co.za>

Content
> I've updated the patch with the comments from the review Thanks William for your contribution, I commited your fix. I just made a minor change on "if (cwd && use_bytes) {": you forgot to remove test now useless test on cwd, and I dropped { and } to make to short more readable (Note: the PEP 7 requires to put "}" and "else {" on two lines). Ok, I just took 5 years to get Python 2 features in Python 3 :-)

Content

> I've updated the patch with the comments from the review
Thanks William for your contribution, I commited your fix.
I just made a minor change on "if (cwd && use_bytes) {": you forgot to remove test now useless test on cwd, and I dropped { and } to make to short more readable (Note: the PEP 7 requires to put "}" and "else {" on two lines).
Ok, I just took 5 years to get Python 2 features in Python 3 :-)

History
Date	User	Action	Args
2015年04月24日 22:26:40	vstinner	set	recipients: + vstinner, loewis, terry.reedy, pitrou, giampaolo.rodola, boya, santoso.wijaya, python-dev, zach.ware, serhiy.storchaka, worr
2015年04月24日 22:26:40	vstinner	set	messageid: <1429914400.15.0.868795997397.issue9246@psf.upfronthosting.co.za>
2015年04月24日 22:26:40	vstinner	link	issue9246 messages
2015年04月24日 22:26:39	vstinner	create

homepage