homepage

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author gvanrossum
Recipients
Date 2006年08月09日.21:58:11
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Logged In: YES 
user_id=6380
+1.
minor nits:
in the main patch: instead of
+ if line.endswith('\n'):
+ last_line_lfend = True
+ else:
+ last_line_lfend = False
you can just use
 last_line_lfend = line.endswith('\n')
in the unit test: instead of
 if type(a) != type(0):
use
 if not isinstance(a, int):
so that if some future release changes file.closed to return
a bool (as it should :-) this test won't break.
Is tehre a reason why you're not patching the fp.readline()
call in parse_multipart()? It would seem to have the same
issue (even if it isn't used in Zope :-).
History
Date User Action Args
2007年08月23日 14:29:11adminlinkissue1112549 messages
2007年08月23日 14:29:11admincreate

AltStyle によって変換されたページ (->オリジナル) /