Message 240412 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	vstinner
Recipients	alex, benjamin.peterson, piotr.dobrogost, pitrou, serhiy.storchaka, stutzbach, vstinner
Date	2015年04月10日.07:52:08
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1428652328.52.0.362436936208.issue21859@psf.upfronthosting.co.za>

Content
> Slightly corrected docstrings (but for larger changes C and Python implementations should be changed consistently). I reviewed pyio_fileio_9.patch. The main issue is that I don't understand how self._fd is set to None. In the C implemented, it's set to -1 even if closefd is False. For comments on docstrings which also concern the C code, can you maybe open a new issue with a reference to this issue or maybe even a link to my review, if you don't want to modify them in this issue?

Content

> Slightly corrected docstrings (but for larger changes C and Python implementations should be changed consistently).
I reviewed pyio_fileio_9.patch. The main issue is that I don't understand how self._fd is set to None. In the C implemented, it's set to -1 even if closefd is False.
For comments on docstrings which also concern the C code, can you maybe open a new issue with a reference to this issue or maybe even a link to my review, if you don't want to modify them in this issue?

History
Date	User	Action	Args
2015年04月10日 07:52:08	vstinner	set	recipients: + vstinner, pitrou, benjamin.peterson, stutzbach, alex, piotr.dobrogost, serhiy.storchaka
2015年04月10日 07:52:08	vstinner	set	messageid: <1428652328.52.0.362436936208.issue21859@psf.upfronthosting.co.za>
2015年04月10日 07:52:08	vstinner	link	issue21859 messages
2015年04月10日 07:52:08	vstinner	create

homepage