Message239792
| Author |
vstinner |
| Recipients |
ezio.melotti, michael.foord, pitrou, serhiy.storchaka, vstinner |
| Date |
2015年04月01日.12:08:27 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<CAMpsgwajrKdLo7NuW+QLOS6dOehunkt7khAdCR=Woup0Cz8Wjg@mail.gmail.com> |
| In-reply-to |
<1427889748.89.0.966320062587.issue23838@psf.upfronthosting.co.za> |
| Content |
2015年04月01日 14:02 GMT+02:00 Serhiy Storchaka <report@bugs.python.org>:
> getlines() already returns an empty list on OSError.
Oh, I misread getlines(), you're right.
> Clearing the cache on MemoryError will help to avoid other MemoryErrors. And after this there is a large chance
I agree, but please avoid retrying on MemoryError. IMO clearing the
cache and return [] is enough.
> If don't change linecache, then we should patch all places where linecache is used: traceback, idlelib, warnings, trace, debugger, etc. I intentionally made the fix at the low level, so it fixes all issues in one place.
I agree. |
|