Message238602
| Author |
berker.peksag |
| Recipients |
Arfrever, berker.peksag, ezio.melotti, martin.panter, rhettinger, serhiy.storchaka |
| Date |
2015年03月20日.03:30:02 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1426822202.36.0.887116341318.issue22831@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Looks good. A couple of comments:
* Doc/includes/email-* changes have already been committed.
* There is a commented-out line in Tools/scripts/nm2def.py:
- f.close()
+ # f.close()
* The patch is huge, I'd commit Tools/ and Lib/test/ parts separately.
* Most of the open(..., 'r') usages can be changed to open(...)
* It would be good to add context management protocol support to http.client.HTTPConnection. |
|