Message238214
| Author |
steve.dower |
| Recipients |
serhiy.storchaka, steve.dower, tim.golden, vstinner, zach.ware |
| Date |
2015年03月16日.15:49:24 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1426520964.86.0.42523558047.issue23668@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
It looks like mmap uses pure Win32 APIs for the Windows implementation, and so _chsize_s isn't necessary. There is a comment "todo: need ... a 'chsize' analog" in the file, but I'm not actually sure what that means.
I've made some minor changes from the review, but I had a question about possibly defining HAVE_[F]TRUNCATE in *.c rather than *.h. See the review, and I'll update the patch once we've figured that out. |
|