Message238026
| Author |
benhoyt |
| Recipients |
benhoyt, python-dev, scott.dial, serhiy.storchaka, vstinner |
| Date |
2015年03月13日.12:53:30 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1426251210.7.0.567034720947.issue23605@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
> I don't understand your benchmark. Do you mean that os.walk() is slower
> with fast_bottom-up.patch because islink() is called or because I replaced
> "for entry in scandir(top):" with "entry = next(scandir_it)"?
No, sorry, I was making two separate comments: 1) the code's gotten quite a bit more complex (and if it needs to be that way for correctness, I'm okay with that), and 2) I'm surprised at how fast it still is.
> Are you testing the top-bottom or bottom-up?
My benchmark.py calls os.walk() with topdown=True, which is the default. I was testing the Python 3.4 version of os.walk() via listdir against your fast_bottom-up.patch.
I'm keen to look into this a bit further, but it won't be today. |
|