Message 236316 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	benjamin.peterson
Recipients	benjamin.peterson, pkt, serhiy.storchaka, vstinner
Date	2015年02月20日.18:07:23
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1424455640.2596328.230260237.256CD332@webmail.messagingengine.com>
In-reply-to	<2088807.jOZ8g1NGfQ@raxxla>

Content
On Fri, Feb 20, 2015, at 12:39, Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > > I think it looks fine except why do you cast PyUnicode_LENGTH to size_t in > > the comparison? > > To silence compiler warning. PyUnicode_LENGTH is signed, right hand is > unsigned. Okay. > > > I also wonder if we should have PyObject_NEW now. > > We have PyObject_NEW. Can we use here then?

Content

On Fri, Feb 20, 2015, at 12:39, Serhiy Storchaka wrote:
> 
> Serhiy Storchaka added the comment:
> 
> > I think it looks fine except why do you cast PyUnicode_LENGTH to size_t in
> > the comparison?
> 
> To silence compiler warning. PyUnicode_LENGTH is signed, right hand is 
> unsigned.
Okay.
> 
> > I also wonder if we should have PyObject_NEW now.
> 
> We have PyObject_NEW.
Can we use here then?

History
Date	User	Action	Args
2015年02月20日 18:07:23	benjamin.peterson	set	recipients: + benjamin.peterson, vstinner, serhiy.storchaka, pkt
2015年02月20日 18:07:23	benjamin.peterson	link	issue23490 messages
2015年02月20日 18:07:23	benjamin.peterson	create

homepage