Message 235458 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	benhoyt
Recipients	abacabadabacaba, akira, benhoyt, giampaolo.rodola, josh.r, pitrou, socketpair, tebeka, tim.golden, vstinner
Date	2015年02月06日.01:37:14
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1423186637.36.0.30622180159.issue22524@psf.upfronthosting.co.za>

Content
Victor, I'd love to push forward with this (I doubt it's going to make alpha 1 on February 8, but hopefully alpha 2 on March 8). It seems pretty settled that we need to use the all-C version I've created, especially for Linux. Can you please review scandir-2.patch? It's on Rietveld here: http://bugs.python.org/review/22524/#ps13104 You can see what changed between scandir-1.patch and scandir-2.patch more easily here: https://github.com/benhoyt/scandir/commit/d4e2d7083319ed8988aef6ed02d670fb36a00a33 Also, here is just the scandir C code in its own file: https://github.com/benhoyt/scandir/blob/d4e2d7083319ed8988aef6ed02d670fb36a00a33/posixmodule_scandir_main.c One other open question is: should it go into CPython's posixmodule.c as I have it in the patch, or should I try to separate it out?

Content

Victor, I'd love to push forward with this (I doubt it's going to make alpha 1 on February 8, but hopefully alpha 2 on March 8).
It seems pretty settled that we need to use the all-C version I've created, especially for Linux.
Can you please review scandir-2.patch? It's on Rietveld here: http://bugs.python.org/review/22524/#ps13104
You can see what changed between scandir-1.patch and scandir-2.patch more easily here: https://github.com/benhoyt/scandir/commit/d4e2d7083319ed8988aef6ed02d670fb36a00a33
Also, here is just the scandir C code in its own file: https://github.com/benhoyt/scandir/blob/d4e2d7083319ed8988aef6ed02d670fb36a00a33/posixmodule_scandir_main.c
One other open question is: should it go into CPython's posixmodule.c as I have it in the patch, or should I try to separate it out?

History
Date	User	Action	Args
2015年02月06日 01:37:17	benhoyt	set	recipients: + benhoyt, tebeka, pitrou, vstinner, giampaolo.rodola, tim.golden, abacabadabacaba, akira, socketpair, josh.r
2015年02月06日 01:37:17	benhoyt	set	messageid: <1423186637.36.0.30622180159.issue22524@psf.upfronthosting.co.za>
2015年02月06日 01:37:17	benhoyt	link	issue22524 messages
2015年02月06日 01:37:15	benhoyt	create

homepage