Message235093
| Author |
martin.panter |
| Recipients |
barry, ethan.furman, gregory.p.smith, martin.panter, r.david.murray, takluyver |
| Date |
2015年01月31日.09:46:32 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1422697592.93.0.0739211581788.issue23342@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Maybe you don’t want to touch the implementation of the "older high-level API" for fear of subtly breaking something, but for clarification, and perhaps documentation, would the old functions now be equivalent to this?
def call(***):
# Verify PIPE not in (stdout, stderr) if needed
return run(***).returncode
def check_call(***):
# Verify PIPE not in (stdout, stderr) if needed
run(***, check=True)
def check_output(***):
# Verify stderr != PIPE if needed
return run(***, check=True, stdout=PIPE)
If they are largely equivalent, perhaps simplify the documentation of them in terms of run(), and move them closer to the run() documentation.
Is it worth making the CalledProcessError exception a subclass of CompletedProcess? They seem to be basically storing the same information. |
|