Message 234864 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	vstinner
Recipients	gvanrossum, pitrou, vstinner, yselivanov
Date	2015年01月27日.23:26:04
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1422401164.15.0.145241609657.issue23333@psf.upfronthosting.co.za>

Content
Oh, accept_error.patch causes issues with the new SSL implementation. SSLProtocol.feed_data() is called before SSLProtocol.connection_made() is called. _SelectorSocketTransport constructor calls loop.add_reader() immediatly, but it only schedules a call to protocol.connection_made() with loop.call_soon(). The call to loop.add_reader() should maybe be scheduled after the call to connection_made()? To ensure that protocol methods (feed_data) are not called before connection_made() has been called.

Content

Oh, accept_error.patch causes issues with the new SSL implementation. SSLProtocol.feed_data() is called before SSLProtocol.connection_made() is called. _SelectorSocketTransport constructor calls loop.add_reader() immediatly, but it only schedules a call to protocol.connection_made() with loop.call_soon().
The call to loop.add_reader() should maybe be scheduled after the call to connection_made()? To ensure that protocol methods (feed_data) are not called before connection_made() has been called.

History
Date	User	Action	Args
2015年01月27日 23:26:04	vstinner	set	recipients: + vstinner, gvanrossum, pitrou, yselivanov
2015年01月27日 23:26:04	vstinner	set	messageid: <1422401164.15.0.145241609657.issue23333@psf.upfronthosting.co.za>
2015年01月27日 23:26:04	vstinner	link	issue23333 messages
2015年01月27日 23:26:04	vstinner	create

homepage