Message 231848 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	josh.r
Recipients	Antony.Lee, josh.r, pitrou, rhettinger, serhiy.storchaka, zach.ware
Date	2014年11月29日.02:57:33
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1417229856.03.0.888394795645.issue22955@psf.upfronthosting.co.za>

Content
I've made a patch that I believe should cover all three cases, including tests. In addition to the pickling behavior, I've made two other changes: 1. methodcaller verifies during construction that the name is a string (PyUnicode), and interns it; attrgetter did this already, and I tweaked methodcaller to match for correctness and performance reasons 2. I added proper repr functionality to all three objects. Partially this is just to make it look nicer, but it was also a decent way to spot verify that the pickle/unpickle sequence behaved correctly Anyone care to review?

Content

I've made a patch that I believe should cover all three cases, including tests.
In addition to the pickling behavior, I've made two other changes:
1. methodcaller verifies during construction that the name is a string (PyUnicode), and interns it; attrgetter did this already, and I tweaked methodcaller to match for correctness and performance reasons
2. I added proper repr functionality to all three objects. Partially this is just to make it look nicer, but it was also a decent way to spot verify that the pickle/unpickle sequence behaved correctly
Anyone care to review?

History
Date	User	Action	Args
2014年11月29日 02:57:36	josh.r	set	recipients: + josh.r, rhettinger, pitrou, zach.ware, serhiy.storchaka, Antony.Lee
2014年11月29日 02:57:36	josh.r	set	messageid: <1417229856.03.0.888394795645.issue22955@psf.upfronthosting.co.za>
2014年11月29日 02:57:35	josh.r	link	issue22955 messages
2014年11月29日 02:57:35	josh.r	create

homepage