Message228548
| Author |
vstinner |
| Recipients |
belopolsky, gladman, mark.dickinson, pitrou, scoder, serhiy.storchaka, vstinner, wolma |
| Date |
2014年10月05日.08:58:44 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1412499524.34.0.382353092212.issue22486@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Why patching fraction.Fraction constructor instead of fractions.gcd()?
I don't like the idea of having two functions, math.gcd and fractions.gcd, which do almost the same, but one is slow, whereas the other is fast. It's harder to write efficient code working on Python < 3.5 (use fractions) and Python >= 3.5 (use math or fractions?).
I suggest to modify fractions.gcd() to use math.gcd() if the two parameters are int. We just have to adjust the sign: if the second parameter is negative, return -math.gcd(a, b). (I guess that we have unit tests for fractions.gcd checking the 4 cases for signed parameters.) |
|