Message 226764 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	vstinner
Recipients	David.Edelsohn, serhiy.storchaka, vstinner
Date	2014年09月11日.11:18:08
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1410434289.32.0.896963264251.issue22336@psf.upfronthosting.co.za>

Content
I read tkinter_pymem_2.patch. Remaining calls to ckalloc(): * they are only used to allocate events passed later to Tcl_ThreadQueueEvent(). Tcl_ThreadQueueEvent doc explicitly says that the memory must be allocated by Tcl_Alloc or ckalloc, so it's correct (PyMem cannot be used). Remaining calls to ckfree(): * Tkapp_SplitList() calls ckfree() on memory allocated by Tcl_SplitList(), it's correct. * Tkapp_CallDeallocArgs() ckfree() on memory allocated by PyMem_Malloc() => wrong (see my review on Rietveld).

Content

I read tkinter_pymem_2.patch.
Remaining calls to ckalloc():
* they are only used to allocate events passed later to Tcl_ThreadQueueEvent(). Tcl_ThreadQueueEvent doc explicitly says that the memory must be allocated by Tcl_Alloc or ckalloc, so it's correct (PyMem cannot be used).
Remaining calls to ckfree():
* Tkapp_SplitList() calls ckfree() on memory allocated by Tcl_SplitList(), it's correct.
* Tkapp_CallDeallocArgs() ckfree() on memory allocated by PyMem_Malloc() => wrong (see my review on Rietveld).

History
Date	User	Action	Args
2014年09月11日 11:18:09	vstinner	set	recipients: + vstinner, serhiy.storchaka, David.Edelsohn
2014年09月11日 11:18:09	vstinner	set	messageid: <1410434289.32.0.896963264251.issue22336@psf.upfronthosting.co.za>
2014年09月11日 11:18:09	vstinner	link	issue22336 messages
2014年09月11日 11:18:08	vstinner	create

homepage