Message224510
| Author |
zach.ware |
| Recipients |
larry, loewis, serhiy.storchaka, zach.ware |
| Date |
2014年08月01日.17:01:13 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1406912473.5.0.188499392856.issue20170@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Another nit to pick: long lines in docstrings. There are several lines about 75-78 characters long in several different docstrings, which look absolutely terrible when you try "import os;help(os)" on an 80-character-wide terminal due to an 8 character indent. Blame can be spread pretty far and wide on this, but I wonder if Clinic should enforce a 72 character limit on docstring lines to try to mitigate this?
Other than that (and the fix to utime mentioned earlier), I don't see anything obviously wrong with the patch, though I admit to not having read through the whole thing (it's huge!). |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2014年08月01日 17:01:13 | zach.ware | set | recipients:
+ zach.ware, loewis, larry, serhiy.storchaka |
| 2014年08月01日 17:01:13 | zach.ware | set | messageid: <1406912473.5.0.188499392856.issue20170@psf.upfronthosting.co.za> |
| 2014年08月01日 17:01:13 | zach.ware | link | issue20170 messages |
| 2014年08月01日 17:01:13 | zach.ware | create |
|