Message223927
| Author |
terry.reedy |
| Recipients |
Lita.Cho, ned.deily, terry.reedy |
| Date |
2014年07月25日.07:45:41 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1406274342.14.0.580030811774.issue22065@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
On #22061, Serhiy Storchaka posted turtledemo_menu.patch, which is unrelated to that issue. Issues in that patch.
* It mistakenly includes the tkinter_restore_empty_methods.patch that does belongs to 22061.
* It will not apply any more, especially to 3.4 as it is now.
* Removing the gridding of the Menu seems like a mistake, or else the rest of the grid code should be revised. I will test this.
Serhiy claims the patch "replaces obsolete and non-working menu creation code by modernized code. Now menu should be correctly displayed on MacOS."
'Obsolete' is correct' The current code uses Menubutton, "obsolete since Tk8.0". Updating, even for 2.7, would probably be a good idea.
As for 'non-working': the current code works on Windows, but I have no idea on Linux or Mac. Can either of you comment? I certainly would want an updated patch tested on more than Windows. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2014年07月25日 07:45:42 | terry.reedy | set | recipients:
+ terry.reedy, ned.deily, Lita.Cho |
| 2014年07月25日 07:45:42 | terry.reedy | set | messageid: <1406274342.14.0.580030811774.issue22065@psf.upfronthosting.co.za> |
| 2014年07月25日 07:45:42 | terry.reedy | link | issue22065 messages |
| 2014年07月25日 07:45:41 | terry.reedy | create |
|