Message 220945 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	serhiy.storchaka
Recipients	benjamin.peterson, pitrou, serhiy.storchaka, stutzbach
Date	2014年06月18日.17:52:21
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1403113942.14.0.852744973704.issue21802@psf.upfronthosting.co.za>

Content
Current implementation of BufferedRWPair.close() is: def close(self): self.writer.close() self.reader.close() When self.writer.close() raises an exception, self.reader left non-closed. This can cause file description leak unless GC sweep it. Proposed patch fixes this issue. With applied patch for issue21715 it would be a little simpler.

Content

Current implementation of BufferedRWPair.close() is:
 def close(self):
 self.writer.close()
 self.reader.close()
When self.writer.close() raises an exception, self.reader left non-closed. This can cause file description leak unless GC sweep it.
Proposed patch fixes this issue. With applied patch for issue21715 it would be a little simpler.

History
Date	User	Action	Args
2014年06月18日 17:52:22	serhiy.storchaka	set	recipients: + serhiy.storchaka, pitrou, benjamin.peterson, stutzbach
2014年06月18日 17:52:22	serhiy.storchaka	set	messageid: <1403113942.14.0.852744973704.issue21802@psf.upfronthosting.co.za>
2014年06月18日 17:52:22	serhiy.storchaka	link	issue21802 messages
2014年06月18日 17:52:21	serhiy.storchaka	create

homepage