Message 220084 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	bkabrda
Recipients	benjamin.peterson, bkabrda, pitrou, serhiy.storchaka, stutzbach
Date	2014年06月09日.08:12:04
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1402301528.34.0.543361606772.issue21679@psf.upfronthosting.co.za>

Content
Thanks a lot for the code review! I'm attaching a revised version of the patch. Fixes I made: - added check whether PyLong_AsLong returned an error - removed "ADD_INTERNED(_blksize)" and "PyObject *_PyIO_str__blksize;" - I noticed that these are only necessary when exported by _iomodule.h, which isn't needed for _blksize ATM - moved blksize to a place of fileio structure where it won't create unnecessary padding I hope attaching the version 2 of the patch here is ok, if I should have attached it in the code review tool somehow, please let me know.

Content

Thanks a lot for the code review! I'm attaching a revised version of the patch. Fixes I made:
- added check whether PyLong_AsLong returned an error
- removed "ADD_INTERNED(_blksize)" and "PyObject *_PyIO_str__blksize;" - I noticed that these are only necessary when exported by _iomodule.h, which isn't needed for _blksize ATM
- moved blksize to a place of fileio structure where it won't create unnecessary padding
I hope attaching the version 2 of the patch here is ok, if I should have attached it in the code review tool somehow, please let me know.

History
Date	User	Action	Args
2014年06月09日 08:12:08	bkabrda	set	recipients: + bkabrda, pitrou, benjamin.peterson, stutzbach, serhiy.storchaka
2014年06月09日 08:12:08	bkabrda	set	messageid: <1402301528.34.0.543361606772.issue21679@psf.upfronthosting.co.za>
2014年06月09日 08:12:08	bkabrda	link	issue21679 messages
2014年06月09日 08:12:07	bkabrda	create

homepage