Message 218983 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	Lita.Cho
Recipients	Lita.Cho, Ramchandra Apte, ezio.melotti, jesstess, kbk, orsenthil, rhettinger
Date	2014年05月23日.18:22:36
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1400869358.32.0.389738732141.issue17172@psf.upfronthosting.co.za>

Content
I tested the patch and it looks correct upon inspection. It looks like it applies cleanly and a straight forward solution. I made a slight change so that when the Demo exits, it has a better message. I also added the change to the NEWS.txt file. I also ran the IDLE tests, and everything passed. I didn't see new tests added, but I am not sure if that is needed, since we are just adding a menu binding. I've attached my patch with the changes listed above. It should be ready for review.

Content

I tested the patch and it looks correct upon inspection. It looks like it applies cleanly and a straight forward solution. 
I made a slight change so that when the Demo exits, it has a better message. I also added the change to the NEWS.txt file. 
I also ran the IDLE tests, and everything passed. I didn't see new tests added, but I am not sure if that is needed, since we are just adding a menu binding.
I've attached my patch with the changes listed above. It should be ready for review.

History
Date	User	Action	Args
2014年05月23日 18:22:38	Lita.Cho	set	recipients: + Lita.Cho, rhettinger, kbk, orsenthil, ezio.melotti, jesstess, Ramchandra Apte
2014年05月23日 18:22:38	Lita.Cho	set	messageid: <1400869358.32.0.389738732141.issue17172@psf.upfronthosting.co.za>
2014年05月23日 18:22:38	Lita.Cho	link	issue17172 messages
2014年05月23日 18:22:37	Lita.Cho	create

homepage