Message 217495 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	pitrou
Recipients	Anton.Afanasyev, pitrou, rhettinger
Date	2014年04月29日.08:39:22
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1398760762.35.0.930166917982.issue21321@psf.upfronthosting.co.za>

Content
Thanks. Could you also add a test for the islice_reduce additions? Or is it already tested? I suspect there's a reference leak there: after calling PyObject_GetIter, you should always Py_DECREF(empty_list). Also, with the "O" code, Py_BuildValue will take a new reference to empty_it, so you should use the "N" code instead.

Content

Thanks. Could you also add a test for the islice_reduce additions? Or is it already tested?
I suspect there's a reference leak there: after calling PyObject_GetIter, you should always Py_DECREF(empty_list).
Also, with the "O" code, Py_BuildValue will take a new reference to empty_it, so you should use the "N" code instead.

History
Date	User	Action	Args
2014年04月29日 08:39:22	pitrou	set	recipients: + pitrou, rhettinger, Anton.Afanasyev
2014年04月29日 08:39:22	pitrou	set	messageid: <1398760762.35.0.930166917982.issue21321@psf.upfronthosting.co.za>
2014年04月29日 08:39:22	pitrou	link	issue21321 messages
2014年04月29日 08:39:22	pitrou	create

homepage