Message216849
| Author |
orsenthil |
| Recipients |
bbrazil, ctheune, giampaolo.rodola, orsenthil, pitrou, r.david.murray, sspapilin |
| Date |
2014年04月19日.07:34:42 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1397892884.36.0.754928748544.issue15002@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Christian's patch is good.It helps in setting the socket.makefile file descriptor to a well behaving well file close wrapper and thus will help us prevent some tricky fd close issues.
I added tests for coverage to ensure that we are asserting the type and covering all the methods in urllib.response. Attaching the patch built on top of Chritians one. |
|