Message 216283 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	Dima.Tisnek
Recipients	Dima.Tisnek, benjamin.peterson, python-dev
Date	2014年04月15日.09:34:17
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1397554457.58.0.99289799944.issue21191@psf.upfronthosting.co.za>

Content
Banjamin, Your patch looks good to me! I have a small concern regarding "We now know we will succeed..." -- should there be a test case to make sure fstat test here matches whatever test is/was done on a lower level? Or is your code now such that it will explicitly succeed because it doesn't call anything that can fail after the comment?

Content

Banjamin, Your patch looks good to me!
I have a small concern regarding "We now know we will succeed..." -- should there be a test case to make sure fstat test here matches whatever test is/was done on a lower level?
Or is your code now such that it will explicitly succeed because it doesn't call anything that can fail after the comment?

History
Date	User	Action	Args
2014年04月15日 09:34:17	Dima.Tisnek	set	recipients: + Dima.Tisnek, benjamin.peterson, python-dev
2014年04月15日 09:34:17	Dima.Tisnek	set	messageid: <1397554457.58.0.99289799944.issue21191@psf.upfronthosting.co.za>
2014年04月15日 09:34:17	Dima.Tisnek	link	issue21191 messages
2014年04月15日 09:34:17	Dima.Tisnek	create

homepage