Message215546
| Author |
serhiy.storchaka |
| Recipients |
Lucretiel, ezio.melotti, mrabarnett, serhiy.storchaka |
| Date |
2014年04月04日.18:22:58 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<3837898.Ef8258QMgz@raxxla> |
| In-reply-to |
<1395351472.15.0.748115651158.issue20998@psf.upfronthosting.co.za> |
| Content |
Both patch are almost equivalent (my patch is much simpler but perhaps
Matthew's approach is more correct in long perspective).
Unfortunately Rietvield doesn't work with Matthew's patch, so I have added my
comments here.
> - (!ctx->match_all || ctx->ptr == state->end)) {
> + ctx->ptr == state->end) {
Why this check is not needed anymore?
> - status = SRE(match)(state, pattern + 2*prefix_skip);
> + status = SRE(match)(state, pattern + 2*prefix_skip,
state->match_all);
> - status = SRE(match)(state, pattern + 2);
> + status = SRE(match)(state, pattern + 2, state->match_all);
state->match_all is used but it is never initialized. |
|