Message212594
| Author |
r.david.murray |
| Recipients |
barry, michael.henry, r.david.murray, varun |
| Date |
2014年03月02日.21:30:24 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1393795825.16.0.804176119394.issue11558@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Yes, this is the right idea.
A couple of comments: I'm a bit concerned that the AttributeError might catch something other than the specific error generated by this case, but since that is unlikely and in any case would be revealed by the chained traceback, I think this is OK, and not worth the effort it
would take to narrow it.
The test, while correct, is IMO overbroad. I prefer to only look for the essential parts of the message, which in this case would be mention of 'attach' and 'non-multipart'. Thus the regex I suggested on irc for use in the test: 'attach.*non-multipart'.
Also, you should wrap all lines to less than 79 characters, per PEP8. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2014年03月02日 21:30:25 | r.david.murray | set | recipients:
+ r.david.murray, barry, michael.henry, varun |
| 2014年03月02日 21:30:25 | r.david.murray | set | messageid: <1393795825.16.0.804176119394.issue11558@psf.upfronthosting.co.za> |
| 2014年03月02日 21:30:25 | r.david.murray | link | issue11558 messages |
| 2014年03月02日 21:30:24 | r.david.murray | create |
|