Message210496
| Author |
mark.dickinson |
| Recipients |
gdr@garethrees.org, mark.dickinson, ncoghlan, pitrou, skrah, vstinner |
| Date |
2014年02月07日.17:08:26 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1391792907.17.0.0181454947372.issue20539@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Thinking about it, `ValueError` seems like the right exception type: nothing's actually overflowing, because we haven't even tried to do any computation. This is just a limitation of what `math.factorial` is prepared to accept as input (and perhaps that limitation should be documented).
Here's a patch. Bikeshedding about the exception type and the exception message is welcome. |
|