Message 209073 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	ncoghlan
Recipients	brett.cannon, larry, ncoghlan, terry.reedy, yselivanov
Date	2014年01月24日.13:56:35
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1390571796.12.0.822702743478.issue20223@psf.upfronthosting.co.za>

Content
Yury, I believe the review comments from Rietveld go to the address you have registered as primary in the tracker, so that's currently your address with the ".ml" suffix rather than your main one. My only suggestion was to use ._partialmethod for the attribute name, rather than __partialmethod__, since this feels a bit more like an ordinary private attribute, rather than a new protocol. Lots of introspection tools deliberately display dunder names, and that doesn't really feel appropriate here.

Content

Yury, I believe the review comments from Rietveld go to the address you have registered as primary in the tracker, so that's currently your address with the ".ml" suffix rather than your main one.
My only suggestion was to use ._partialmethod for the attribute name, rather than __partialmethod__, since this feels a bit more like an ordinary private attribute, rather than a new protocol. Lots of introspection tools deliberately *display* dunder names, and that doesn't really feel appropriate here.

History
Date	User	Action	Args
2014年01月24日 13:56:36	ncoghlan	set	recipients: + ncoghlan, brett.cannon, terry.reedy, larry, yselivanov
2014年01月24日 13:56:36	ncoghlan	set	messageid: <1390571796.12.0.822702743478.issue20223@psf.upfronthosting.co.za>
2014年01月24日 13:56:36	ncoghlan	link	issue20223 messages
2014年01月24日 13:56:35	ncoghlan	create

homepage