Message208123
| Author |
larry |
| Recipients |
barry, brett.cannon, larry, meador.inge, skrah, tim.peters, yselivanov |
| Date |
2014年01月14日.23:23:43 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1389741824.85.0.964322394075.issue20189@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Updated the patch. (Diff #2 apparently didn't apply cleanly, so we didn't get a review link.)
Old-guard core devs: I'm *really* desperate for a review of this patch. You don't have to review everything thing, just these files:
* Include/object.h
* Objects/descrobject.c
* Objects/methodobject.c
* Objects/typeobject.c
I can get a different reviewer for the other files. But I worry about touching these tender bits of the type system and I want to make sure that
a) I haven't done something awful, and
b) I haven't missed something important.
Just that part of the diff is 345 lines, and it's pretty regular. I'd be surprised if it took you a whole hour.
If you have any questions email me, I'd be thrilled to answer 'em if it means I can get this patch checked in. Maintaining the patch is overhead that I just don't need during the Derby. |
|