Message207876
| Author |
zach.ware |
| Recipients |
larry, zach.ware |
| Date |
2014年01月10日.19:55:24 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1389383724.62.0.0959269080002.issue20172@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Here's the complete patch for PC/winreg.c. One clinic/signature/pydoc issue I've noticed:
>>> help(winreg.HKEYType.Close)
Help on method_descriptor:
Close(...) <--- No signature
Close() <--- Extra
Closes the underlying Windows handle.
If the handle is already closed, no error is raised.
>>> winreg.HKEYType.Close.__doc__
'Close()\nCloses the underlying Windows handle.\n\nIf the handle is already clos
ed, no error is raised.'
>>> winreg.HKEYType.Close.__text_signature__
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: 'method_descriptor' object has no attribute '__text_signature__'
My gut feeling is that it's a Clinic issue; Clinic should be adding 'self' to the signature, which should then be picked up by the __text_signature__ parser, and used by inspect and pydoc.
As far as the patch, one point I'd like some extra scrutiny on is the HKEY_converter (and C clinic_HKEY_converter). I don't understand how all of the C machinery there works properly, so I can't say with confidence that it is right. It compiles without errors and the tests pass, but beyond that, I can't guarantee anything. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2014年01月10日 19:55:24 | zach.ware | set | recipients:
+ zach.ware, larry |
| 2014年01月10日 19:55:24 | zach.ware | set | messageid: <1389383724.62.0.0959269080002.issue20172@psf.upfronthosting.co.za> |
| 2014年01月10日 19:55:24 | zach.ware | link | issue20172 messages |
| 2014年01月10日 19:55:24 | zach.ware | create |
|