Message 207133 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	MLModel
Recipients	MLModel, gennad, ncoghlan
Date	2014年01月01日.14:02:30
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1388584950.88.0.567436397945.issue20077@psf.upfronthosting.co.za>

Content
Patch looks good to me. I like the choice to drop the parens. This is my first time reviewing a change; did I go through the right mechanics? I clicked Review on the issue's patch, looked at the diff, and a published a message similar to this one. Was I supposed to do something else? Is that message what "Review" is looking for? Was the "Please review" directed at me? Am I supposed to make a comment like "looks good" here? do something else?

Content

Patch looks good to me. I like the choice to drop the parens. This is my first time reviewing a change; did I go through the right mechanics? I clicked Review on the issue's patch, looked at the diff, and a published a message similar to this one. Was I supposed to do something else? Is that message what "Review" is looking for? Was the "Please review" directed at me? Am I supposed to make a comment like "looks good" here? do something else?

History
Date	User	Action	Args
2014年01月01日 14:02:31	MLModel	set	recipients: + MLModel, ncoghlan, gennad
2014年01月01日 14:02:30	MLModel	set	messageid: <1388584950.88.0.567436397945.issue20077@psf.upfronthosting.co.za>
2014年01月01日 14:02:30	MLModel	link	issue20077 messages
2014年01月01日 14:02:30	MLModel	create

homepage