Message206996
| Author |
zach.ware |
| Recipients |
gennad, larry, meador.inge, serhiy.storchaka, vajrasky, zach.ware |
| Date |
2013年12月27日.15:41:40 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1388158900.78.0.626425734745.issue20075@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
The patch looks good to me (aside from extra whitespace on the blank lines in methodobject.c, and I agree with Serhiy about s/brackets/parens/). Also, I like the suggestion of using __text_signature__ instead of '(...)'. However, just to avoid any possible issues with __text_signature__ being blank or missing, I would go with `argspec = getattr(object, '__text_signature__', '') or '(...)'` instead of straight `object.__text_signature__` (and note that there are two places to change in pydoc). |
|