homepage

I thought some more about this approach. I'm +1 on it. The locale
lookup is not time critical, so the table optimization makes sense.
Nice idea, Serhiy !
On 22.12.2013 00:38, Serhiy Storchaka wrote:
> 
> Serhiy Storchaka added the comment:
> 
>> * the patch seems to include some unrelated changes, e.g. the
>> devanagari fixes and a few new mappings
> 
> May be. In any case I have added issue20027 as dependency. New mappings were 
> added when enable UTF-8 locales in makelocalealias.py (I can split this in 
> separate issue).
I think it's better to apply the patches separately, if that's
possible.
>> * the optimize step is called twice for some reason - is this
>> intended ? if yes, please add a comment why this is done
> 
> Actually we should call it in a loop while the size of the table is decreased.
Ok, that makes sense. Still, please add a comment on why this is necessary.
>> * the patch would need some tests to make sure that the removed
>> aliases indeed still map to the correct C locale strings
> 
> Currently the makelocalealias.py is such manual test. test_locale contains 
> multiple tests for different locales. I'll add several new cases.
Great.
Thanks,
-- 
Marc-Andre Lemburg
eGenix.com