Message206507
| Author |
skrah |
| Recipients |
ezio.melotti, facundobatista, mark.dickinson, rhettinger, skrah, zach.ware |
| Date |
2013年12月18日.11:57:23 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1387367844.47.0.47107486885.issue20008@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Assigning to myself, since my private 100% coverage test suite
would have to be updated as well.
I have just glanced at the patch and only have some superficial
remarks:
In any case, I would prefer a patch without stylistic changes. Elimination of "return" is a personal preference, so are the
whitespace changes.
Listing the tests explicitly is sometimes helpful, e.g. one can
comment out tests when tracking down a refleak.
Curiously enough, testing with a "polluted" context is also useful,
since all functions must handle contexts with flags that are already
set.
Finally, I *suspect* no one is using the command line arguments any
more. They were probably used heavily during the design phase of
decimal.py. |
|