Message203369
| Author |
ezio.melotti |
| Recipients |
BreamoreBoy, brett.cannon, ezio.melotti, martin.panter, rnk, serhiy.storchaka, thomaspinckney3, vstinner |
| Date |
2013年11月19日.12:31:38 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1384864299.72.0.476331620278.issue2927@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Here's an updated patch that addresses comments on rietveld and adds a few more tests and docs.
I should also update the what's new, but I have other upcoming changes in the html package so I'll probably do it at the end.
Regarding your concern:
* if people are only using html.escape, then they will get a couple of extra imports, including all the html5 entities, and a re.compile;
* if people are using html.parser, they already have plenty of re.compiles there, and soon html.parser will use unescape too;
* if people are using html.entities they only get an extra re.compile;
Overall I don't think it's a big problem.
As a side node, the "if '&' in s:" in the unescape function could be removed -- I'm not sure it brings any real advantage. This could/should be proved by benchmarks. |
|