Message200649
| Author |
ned.deily |
| Recipients |
ezio.melotti, michael.foord, ned.deily, pitrou, serhiy.storchaka, terry.reedy, vajrasky, vstinner, zach.ware |
| Date |
2013年10月20日.23:01:36 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1382310097.12.0.994610474017.issue18702@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I took a quick look at the revised patch. Clearly, it's too big to review at a detailed level. I tried the approach of running two complete verbose regrtest runs (-m test -v -uall), before and after the patch, and diffing the results in a "smart" diff app. Again, this is extremely tedious: while some simple filtering could be done to mask some differences (like elapsed times and time stamps), the non-deterministic output of many tests remains (and demonstrates how difficult it currently is to automatically compare regrtest run results). I did a spot check of the results and didn't notice any glaring problems and *did* notice that some tests were now being reported as skipped, as expected. Overall, I think this is a useful change to the test suite so I would say apply it to default (for 3.4.0) but I'm ambivalent about applying it to 3.3 at this point. |
|